linux-kernel - Re: [PATCH] HID: i2c-hid: Call device suspend callback before disabling irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 7 Jul 2015 22:49:30 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.com>
To:	Gabriele Mazzotta <gabriele.mzt@...il.com>
cc:	benjamin.tissoires@...hat.com, aduggan@...aptics.com,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: i2c-hid: Call device suspend callback before
 disabling irq

On Tue, 7 Jul 2015, Gabriele Mazzotta wrote:

> The irq is most likely required by the suspend callback, so disable it
> only after the callback had been executed.

It would be nice to have a more verbose changelog here -- i.e. why we want 
to do such change and what could go wrong if IRQ is disabled too early 
(i.e. what bug is this exactly fixing).

> 
> Signed-off-by: Gabriele Mazzotta <gabriele.mzt@...il.com>

I'd see this as a 4.2 material still. Please let me know if you'd rather 
want to wait for 4.3.

Thanks,

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/