linux-kernel - Re: [PATCH] mm:Change unlabeled block of code to a else block in the function dma_pool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 7 Jul 2015 15:41:06 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Nicholas Krause <xerofoify@...il.com>
Cc:	khalasa@...p.pl, bigeasy@...utronix.de, paulmcquad@...il.com,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm:Change unlabeled block of code to a else block in
 the function dma_pool_free

On Mon,  6 Jul 2015 19:30:31 -0400 Nicholas Krause <xerofoify@...il.com> wrote:

> This fixes the unlabeled block of code after the if statement that
> executes if the passed dma variable of type dma_addr_t minus the
> structure pointer page's dma member is equal to the variable offset
> into a else block as this block should run when the if statement check
> 
> Signed-off-by: Nicholas Krause <xerofoify@...il.com>
> ---
>  mm/dmapool.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/mm/dmapool.c b/mm/dmapool.c
> index fd5fe43..ce7ff4b 100644
> --- a/mm/dmapool.c
> +++ b/mm/dmapool.c
> @@ -434,8 +434,7 @@ void dma_pool_free(struct dma_pool *pool, void *vaddr, dma_addr_t dma)
>  			       "dma_pool_free %s, %p (bad vaddr)/%Lx\n",
>  			       pool->name, vaddr, (unsigned long long)dma);
>  		return;
> -	}
> -	{
> +	} else {
>  		unsigned int chain = page->offset;
>  		while (chain < pool->allocation) {
>  			if (chain != offset) {

This patch has no effect?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/