[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date: Wed, 8 Jul 2015 01:32:26 +0200
From: Oleg Nesterov <oleg@...hat.com>
To: akpm@...ux-foundation.org
Cc: fweisbec@...il.com, cl@...ux.com, riel@...hat.com,
rusty@...tcorp.com.au, tj@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: +
kmod-remove-unecessary-explicit-wide-cpu-affinity-setting.patch
added to -mm tree
Well, sorry for noise.
Let me repeat that I agree with this change, but...
On 07/07, Andrew Morton wrote:
>
> From: Frederic Weisbecker <fweisbec@...il.com>
> Subject: kmod: remove unecessary explicit wide CPU affinity setting
>
> Not only useless it even breaks nohz full. The housekeeping work (general
> kernel internal code that user doesn't care much about) is handled by a
> reduced set of CPUs in nohz full, precisely those that are not included by
> nohz_full= kernel parameters. For example unbound workqueues are handled
> by housekeeping CPUs.
I still think this part of the changelog looks confusing and just wrong.
It is not that it breaks nohz full, unbound workqueues have nothing to
do with housekeeping_mask from the kernel pov. But yes, people can change
->cpumask and this can connect to housekeeping_mask.
Frederic, may I ask you to update the changelog? Although perhaps it was
just me who was confused...
Oleg.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists