lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Tue, 7 Jul 2015 07:47:55 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Axel Lin <axel.lin@...ics.com>
Cc:	Mike Rapoport <mike@...pulab.co.il>,
	Alban Bedel <alban.bedel@...onic-design.de>,
	Stefan Agner <stefan@...er.ch>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: tps6586x: Fix up define for TPS6586X_MAX_REGISTER

On Tue, 07 Jul 2015, Axel Lin wrote:

> The latest valid register is TPS6586X_VERSIONCRC.
> 
> Signed-off-by: Axel Lin <axel.lin@...ics.com>
> ---
>  drivers/mfd/tps6586x.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/tps6586x.c b/drivers/mfd/tps6586x.c
> index e0a2583..ae08b29 100644
> --- a/drivers/mfd/tps6586x.c
> +++ b/drivers/mfd/tps6586x.c
> @@ -52,7 +52,7 @@
>  #define TPS6586X_VERSIONCRC	0xcd
>  
>  /* Maximum register */
> -#define TPS6586X_MAX_REGISTER	(TPS6586X_VERSIONCRC + 1)
> +#define TPS6586X_MAX_REGISTER	TPS6586X_VERSIONCRC
>  
>  struct tps6586x_irq_data {
>  	u8	mask_reg;
> @@ -467,7 +467,7 @@ static bool is_volatile_reg(struct device *dev, unsigned int reg)
>  static const struct regmap_config tps6586x_regmap_config = {
>  	.reg_bits = 8,
>  	.val_bits = 8,
> -	.max_register = TPS6586X_MAX_REGISTER - 1,
> +	.max_register = TPS6586X_MAX_REGISTER,
>  	.volatile_reg = is_volatile_reg,
>  	.cache_type = REGCACHE_RBTREE,
>  };

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ