linux-kernel - Re: [PATCH] [SCSI] FlashPoint: optimize string comparison

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 7 Jul 2015 10:45:32 +0200
From:	Frans Klaver <fransklaver@...il.com>
To:	Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:	khalid@...ehiking.org, JBottomley@...n.com,
	linux-scsi@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] [SCSI] FlashPoint: optimize string comparison

On Tue, Jul 7, 2015 at 7:39 AM, Christophe JAILLET
<christophe.jaillet@...adoo.fr> wrote:
> Stop comparing the strings as soon as we know that they don't match.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
>  drivers/scsi/FlashPoint.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/FlashPoint.c b/drivers/scsi/FlashPoint.c
> index 5c74e4c..24a4d1a 100644
> --- a/drivers/scsi/FlashPoint.c
> +++ b/drivers/scsi/FlashPoint.c
> @@ -6280,8 +6280,10 @@ static unsigned char FPT_scmachid(unsigned char p_card,
>                 match = 1;
>
>                 for (k = 0; k < ID_STRING_LENGTH; k++) {
> -                       if (p_id_string[k] != FPT_scamInfo[i].id_string[k])
> +                       if (p_id_string[k] != FPT_scamInfo[i].id_string[k]) {
>                                 match = 0;
> +                               break;
> +                       }
>                 }
>
>                 if (match) {

Why doesn't this use strncmp?

Thanks,
Frans
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/