linux-kernel - RE: [PATCH] megaraid:Remove no longer required variable ret from the function megasas_sync_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 7 Jul 2015 14:19:46 +0530
From:	Sumit Saxena <sumit.saxena@...gotech.com>
To:	Nicholas Krause <xerofoify@...il.com>,
	Kashyap Desai <kashyap.desai@...gotech.com>
Cc:	Uday Lingala <uday.lingala@...gotech.com>, JBottomley@...n.com,
	"PDL,MEGARAIDLINUX" <megaraidlinux.pdl@...gotech.com>,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: RE: [PATCH] megaraid:Remove no longer required variable ret from the
 function megasas_sync_map_info

-----Original Message-----
From: Nicholas Krause [mailto:xerofoify@...il.com]
Sent: Monday, July 06, 2015 9:43 PM
To: kashyap.desai@...gotech.com
Cc: sumit.saxena@...gotech.com; uday.lingala@...gotech.com;
JBottomley@...n.com; megaraidlinux.pdl@...gotech.com;
linux-scsi@...r.kernel.org; linux-kernel@...r.kernel.org
Subject: [PATCH] megaraid:Remove no longer required variable ret from the
function megasas_sync_map_info

This removes the no longer required variable ret due to this variable only
ever being used at the end of the function megasas_sync_map_info without
changing it's value from the orginal setting of its value to zero due to
this just remove the variable ret and just return the value of zero
directly here in order to indicate to the caller the call to this function
has run successfully without any non recoverable issues.

Signed-off-by: Nicholas Krause <xerofoify@...il.com>
---
 drivers/scsi/megaraid/megaraid_sas_fusion.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c
b/drivers/scsi/megaraid/megaraid_sas_fusion.c
index 46a0f8f..b5a8c65 100644
--- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
+++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
@@ -836,7 +836,7 @@ megasas_get_map_info(struct megasas_instance
*instance)  int  megasas_sync_map_info(struct megasas_instance *instance)
{
-	int ret = 0, i;
+	int i;
 	struct megasas_cmd *cmd;
 	struct megasas_dcmd_frame *dcmd;
 	u32 size_sync_info, num_lds;
@@ -906,7 +906,7 @@ megasas_sync_map_info(struct megasas_instance
*instance)

 	instance->instancet->issue_dcmd(instance, cmd);

-	return ret;
+	return 0;
 }

Acked-by: Sumit Saxena <sumit.saxena@...gotech.com>

 /*
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/