[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 7 Jul 2015 11:33:32 +0000
From: "Wu, Feng" <feng.wu@...el.com>
To: Paolo Bonzini <pbonzini@...hat.com>,
Eric Auger <eric.auger@...aro.org>,
"eric.auger@...com" <eric.auger@...com>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"kvmarm@...ts.cs.columbia.edu" <kvmarm@...ts.cs.columbia.edu>,
"kvm@...r.kernel.org" <kvm@...r.kernel.org>,
"christoffer.dall@...aro.org" <christoffer.dall@...aro.org>,
"marc.zyngier@....com" <marc.zyngier@....com>,
"alex.williamson@...hat.com" <alex.williamson@...hat.com>,
"avi.kivity@...il.com" <avi.kivity@...il.com>,
"mtosatti@...hat.com" <mtosatti@...hat.com>,
"joro@...tes.org" <joro@...tes.org>,
"b.reynal@...tualopensystems.com" <b.reynal@...tualopensystems.com>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"patches@...aro.org" <patches@...aro.org>,
"Wu, Feng" <feng.wu@...el.com>
Subject: RE: [RFC v2 3/6] irq: bypass: Extend skeleton for ARM forwarding
control
> -----Original Message-----
> From: Wu, Feng
> Sent: Tuesday, July 07, 2015 7:24 PM
> To: Paolo Bonzini; Eric Auger; eric.auger@...com;
> linux-arm-kernel@...ts.infradead.org; kvmarm@...ts.cs.columbia.edu;
> kvm@...r.kernel.org; christoffer.dall@...aro.org; marc.zyngier@....com;
> alex.williamson@...hat.com; avi.kivity@...il.com; mtosatti@...hat.com;
> joro@...tes.org; b.reynal@...tualopensystems.com
> Cc: linux-kernel@...r.kernel.org; patches@...aro.org; Wu, Feng
> Subject: RE: [RFC v2 3/6] irq: bypass: Extend skeleton for ARM forwarding
> control
>
>
>
> > -----Original Message-----
> > From: Paolo Bonzini [mailto:pbonzini@...hat.com]
> > Sent: Tuesday, July 07, 2015 7:22 PM
> > To: Wu, Feng; Eric Auger; eric.auger@...com;
> > linux-arm-kernel@...ts.infradead.org; kvmarm@...ts.cs.columbia.edu;
> > kvm@...r.kernel.org; christoffer.dall@...aro.org; marc.zyngier@....com;
> > alex.williamson@...hat.com; avi.kivity@...il.com; mtosatti@...hat.com;
> > joro@...tes.org; b.reynal@...tualopensystems.com
> > Cc: linux-kernel@...r.kernel.org; patches@...aro.org
> > Subject: Re: [RFC v2 3/6] irq: bypass: Extend skeleton for ARM forwarding
> > control
> >
> >
> >
> > On 07/07/2015 13:18, Wu, Feng wrote:
> > > Then I still need assign prod and de-assign prod in
> > > irq_bypass_register_consumer/irq_bypass_unregister_consumer, Right?
> > > Would you please share why this is better.
> >
> > The need to store the consumer->producer link seems to be unique to
> > posted interrupts. It is difficult to say without seeing the PI code,
> > but I prefer to keep the bypass manager as small as possible.
>
> Fine. I will follow your suggestion!
If using the following changes, how can we assign 'prod', we need to use
container_of to get struct kvm_kernel_irqfd and then refer to 'prod', but
we cannot do this in irq_bypass_register_consumer(), right? It is a
common API. But we can only get the associated producer info inside
bypass manager, right?
Thanks,
Feng
struct kvm_kernel_irqfd {
......
struct irq_bypass_consumer cons;
struct irq_bypass_producer *prod;
};
>
> Thanks,
> Feng
>
> >
> > Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists