[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 7 Jul 2015 14:45:03 +0100
From: Lee Jones <lee.jones@...aro.org>
To: Mark Brown <broonie@...nel.org>
Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
kernel@...inux.com, lgirdwood@...il.com
Subject: Re: [RESEND 09/10] regulator: pwm-regulator: Simplify voltage to
duty-cycle call
On Tue, 07 Jul 2015, Mark Brown wrote:
> On Mon, Jul 06, 2015 at 09:58:31AM +0100, Lee Jones wrote:
> > If we reverse some of the logic and change the formula used,
> > we can simplify the function greatly.
>
> > +static int pwm_voltage_to_duty_cycle(struct regulator_dev *rdev, int req_uV)
> > {
> > - struct pwm_regulator_data *drvdata = rdev_get_drvdata(rdev);
>
> You just added this function in the previous patch?
You're right, it does look a little weird contained in a single
patch-set. The submission in the previous patch is the tried and
tested (i.e. in real releases) method written by ST. This patch
contains a simplification provided by me. IMO it looks and performs
better, but doesn't have the same time-under-test that the original
method does. I'm merely ensuring we keep some history in order so
provide and easy way back i.e. revert.
If I have any say at all, I'd really like to keep this piece of
history.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists