linux-kernel - Re: [PATCH 4/5] staging: emxx_udc: add missing usb_ep_set_maxpacket

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 7 Jul 2015 17:10:32 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Robert Baldyga <r.baldyga@...sung.com>, gregkh@...uxfoundation.org,
	balbi@...com
Cc:	devel@...verdev.osuosl.org, hamohammed.sa@...il.com,
	chris@...vick.com, tapaswenipathak@...il.com,
	linux-usb@...r.kernel.org, nicolas.ferre@...el.com,
	hgujulan@...teon.com, mina86@...a86.com,
	linux-kernel@...r.kernel.org, vinc94@...il.com,
	roberta.dobrescu@...il.com, andrzej.p@...sung.com,
	linux-arm-kernel@...ts.infradead.org, m.szyprowski@...sung.com
Subject: Re: [PATCH 4/5] staging: emxx_udc: add missing
 usb_ep_set_maxpacket_limit()

Hello.

On 7/7/2015 5:02 PM, Robert Baldyga wrote:

> Should use usb_ep_set_maxpacket_limit instead of setting
> maxpacket value manually.

> Signed-off-by: Robert Baldyga <r.baldyga@...sung.com>
> ---
>   drivers/staging/emxx_udc/emxx_udc.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)

> diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c
> index 4178d96..f50bf5d 100644
> --- a/drivers/staging/emxx_udc/emxx_udc.c
> +++ b/drivers/staging/emxx_udc/emxx_udc.c
> @@ -3203,7 +3203,8 @@ static void __init nbu2ss_drv_ep_init(struct nbu2ss_udc *udc)
>   		ep->ep.name = gp_ep_name[i];
>   		ep->ep.ops = &nbu2ss_ep_ops;
>
> -		ep->ep.maxpacket = (i == 0 ? EP0_PACKETSIZE : EP_PACKETSIZE);
> +		usb_ep_set_maxpacket_limit(&ep->ep,
> +				(i == 0 ? EP0_PACKETSIZE : EP_PACKETSIZE));

    Inner () not needed.

[...]

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/