linux-kernel - Re: [PATCH][v2] asus-rbtn: new driver for asus radio button for Windows 8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 7 Jul 2015 16:25:18 +0200
From:	Pali Rohár <pali.rohar@...il.com>
To:	Darren Hart <dvhart@...radead.org>
Cc:	Alex Hung <alex.hung@...onical.com>,
	Corentin Chary <corentin.chary@...il.com>,
	"platform-driver-x86@...r.kernel.org" 
	<platform-driver-x86@...r.kernel.org>,
	acpi4asus-user@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][v2] asus-rbtn: new driver for asus radio button for
 Windows 8

On Monday 06 July 2015 15:43:28 Darren Hart wrote:
> On Mon, Jul 06, 2015 at 09:35:40AM +0800, Alex Hung wrote:
> > ATK4001 is an ACPI device for wireless hotkey, similar to how Dell and
> > HP are doing it.  It is just ASUS who decides LED should be controlled
> > by software unlike HP whose LED is driven by hardware pins on mini
> > card.
> 
> Alex, please refrain from top posting on Linux kernel mailing lists, it breaks
> the established practice the readers are setup for.
> 
> Regarding the ATK4001 device, it did sound like it did more than control the
> radios and the associcated LED. If that is all it does, then asus-rbtn is fine.
> If it does something beyond that, we need understand what that is, as a more
> platform-centric name would be more appropriate.
> 
> Thanks,

Yes, I understand too that ATK4001 device has more functions as one for
LED control. And in this case it is not good to use name from one
specific functionality.

And about name:

I chose name rbtn for dell driver because ACPI device in DSDT table is
named RBTN and acpi id is DELRBTN.

I think that acpi-rbtn.c (radio button) is not ideal name for driver
which at SW level controls LED device associated with wireless devices.

I would rather follow acpi device name, but in this case ATK4001 is even
worse name which does not say anything...

Maybe better name could be asus-wireless? Still I do not have any good
name, so choose something...

-- 
Pali Rohár
pali.rohar@...il.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/