[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Tue, 7 Jul 2015 17:15:47 +0200
From: Pali Rohár <pali.rohar@...il.com>
To: Sebastian Reichel <sre@...nel.org>
Cc: Tony Lindgren <tony@...mide.com>,
Ivaylo Dimitrov <ivo.g.dimitrov.75@...il.com>,
Pavel Machek <pavel@....cz>,
Aaro Koskinen <aaro.koskinen@....fi>,
devicetree@...r.kernel.org, linux-omap@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: rx51-battery.ko incompatiblity: board code vs DT
On Tuesday 07 July 2015 17:02:30 Sebastian Reichel wrote:
> Hi,
>
> On Mon, Jul 06, 2015 at 09:44:22PM +0200, Pali Rohár wrote:
> > now I found out that rx51-battery.ko driver register sysnode
> > /sys/class/power_supply/rx51-battery/ when booting with legacy board
> > code. But when booting DT kernel it register sysnode with different name
> > /sys/class/power_supply/n900-battery/
> >
> > Sysfs node for DT kernel comes from Nokia N900 DTS file:
> > arch/arm/boot/dts/omap3-n900.dts
> >
> > I would propose change which change DTS to "rx51-battery" to have it
> > compatible with naming which is for legacy board code. It is just
> > because to have compatibility and same naming scheme and also to make
> > existing programs to work without needing patching them.
> >
> > What do you think?
>
> Change the driver instead (in rx51_battery_probe):
>
> - di->bat.name = dev_name(&pdev->dev);
> + di->bat.name = "rx51-battery"
>
> This will keep the DT ABI stable and avoid introducing the term rx51
> in the device tree file.
>
> -- Sebastian
Perfect, if it works fine can you send & apply patch?
--
Pali Rohár
pali.rohar@...il.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists