linux-kernel - Re: [PATCH] jffs2:Fix error paths return value for the function read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <559D95AF.8060500@nod.at>
Date:	Wed, 08 Jul 2015 23:27:11 +0200
From:	Richard Weinberger <richard@....at>
To:	nick <xerofoify@...il.com>
CC:	David Woodhouse <dwmw2@...radead.org>,
	"linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] jffs2:Fix error paths return value for the function read_unknown

Am 08.07.2015 um 23:20 schrieb nick:
> 
> 
> On 2015-07-08 05:20 PM, Richard Weinberger wrote:
>> On Wed, Jul 8, 2015 at 10:59 PM, Nicholas Krause <xerofoify@...il.com> wrote:
>>> This fixes the error paths in the function read_unknown that return
>>> a value to correctly return -EIO rather then the kernel value for
>>> successful function execution of zero to indicate to this function's
>>> callers that a failure has occurred related to I/O and needs to be
>>> handled by this function's caller.
>>
>> Did you test this patch?
>> I guess not.
>>
> No I don't have hardware why?

It is broken.
Both paths are not fatal errors and the soft error
is already handled by calling jffs2_mark_node_obsolete().

Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/