linux-kernel - Re: [PATCH v2] rhashtable: fix for resize events during table walk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150708.145506.1343225462680114617.davem@davemloft.net>
Date:	Wed, 08 Jul 2015 14:55:06 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	phil@....cc
Cc:	tgraf@...g.ch, sparclinux@...r.kernel.org,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	herbert@...dor.apana.org.au, daniel@...earbox.net,
	geert@...ux-m68k.org, mroos@...ux.ee
Subject: Re: [PATCH v2] rhashtable: fix for resize events during table walk

From: Phil Sutter <phil@....cc>
Date: Mon,  6 Jul 2015 15:51:20 +0200

> If rhashtable_walk_next detects a resize operation in progress, it jumps
> to the new table and continues walking that one. But it misses to drop
> the reference to it's current item, leading it to continue traversing
> the new table's bucket in which the current item is sorted into, and
> after reaching that bucket's end continues traversing the new table's
> second bucket instead of the first one, thereby potentially missing
> items.
> 
> This fixes the rhashtable runtime test for me. Bug probably introduced
> by Herbert Xu's patch eddee5ba ("rhashtable: Fix walker behaviour during
> rehash") although not explicitly tested.
> 
> Fixes: eddee5ba ("rhashtable: Fix walker behaviour during rehash")
> Signed-off-by: Phil Sutter <phil@....cc>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/