linux-kernel - [Patch V2] ioatdma: Ignore IOAT devices under hotplug-capable PCI host bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1436341305-19936-1-git-send-email-jiang.liu@linux.intel.com>
Date:	Wed,  8 Jul 2015 15:41:42 +0800
From:	Jiang Liu <jiang.liu@...ux.intel.com>
To:	Vinod Koul <vinod.koul@...el.com>,
	Dave Jiang <dave.jiang@...el.com>,
	Dan Williams <dan.j.williams@...el.com>,
	Jiang Liu <jiang.liu@...ux.intel.com>,
	Jarkko Nikula <jarkko.nikula@...ux.intel.com>
Cc:	David Woodhouse <dwmw2@...radead.org>,
	Tony Luck <tony.luck@...el.com>, x86@...nel.org,
	linux-kernel@...r.kernel.org, dmaengine@...r.kernel.org
Subject: [Patch V2] ioatdma: Ignore IOAT devices under hotplug-capable PCI host bridge

The dmaengine core assumes that async DMA devices will only be removed
when they not used anymore, or it assumes dma_async_device_unregister()
will only be called by dma driver exit routines. But this assumption is
not true for the IOAT driver, which calls dma_async_device_unregister()
from ioat_remove(). So current IOAT driver doesn't support device
hot-removal because it may cause system crash to hot-remove an inuse
IOAT device.

To support CPU socket hot-removal, all PCI devices, including IOAT
devices embedded in the socket, will be hot-removed. The idea solution
is to enhance the dmaengine core and IOAT driver to support hot-removal,
but that's too hard.

This patch implements a hack to disable IOAT devices under hotplug-capable
CPU socket so it won't break socket hot-removal.

Signed-off-by: Jiang Liu <jiang.liu@...ux.intel.com>
---
Hi Vinod,
	This is a resend of v1, no actual changes except the email title.
Dan and Dave have no objection to this approach, though they haven't
explicitly acked the patch:)
Thanks!
Gerry
---
 drivers/dma/ioat/pci.c |   34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/drivers/dma/ioat/pci.c b/drivers/dma/ioat/pci.c
index 76f0dc688a19..3b8c9b03f4b3 100644
--- a/drivers/dma/ioat/pci.c
+++ b/drivers/dma/ioat/pci.c
@@ -27,6 +27,7 @@
 #include <linux/interrupt.h>
 #include <linux/dca.h>
 #include <linux/slab.h>
+#include <linux/acpi.h>
 #include "dma.h"
 #include "dma_v2.h"
 #include "registers.h"
@@ -148,6 +149,34 @@ alloc_ioatdma(struct pci_dev *pdev, void __iomem *iobase)
 	return d;
 }
 
+/*
+ * The dmaengine core assumes that async DMA devices will only be removed
+ * when they not used anymore, or it assumes dma_async_device_unregister()
+ * will only be called by dma driver exit routines. But this assumption is
+ * not true for the IOAT driver, which calls dma_async_device_unregister()
+ * from ioat_remove(). So current IOAT driver doesn't support device
+ * hot-removal because it may cause system crash to hot-remove inuse IOAT
+ * devices.
+ *
+ * This is a hack to disable IOAT devices under ejectable PCI host bridge
+ * so it won't break PCI host bridge hot-removal.
+ */
+static bool ioat_pci_has_ejectable_acpi_ancestor(struct pci_dev *pdev)
+{
+#ifdef CONFIG_ACPI
+	struct pci_bus *bus = pdev->bus;
+	struct acpi_device *adev;
+
+	while (bus->parent)
+		bus = bus->parent;
+	for (adev = ACPI_COMPANION(bus->bridge); adev; adev = adev->parent)
+		if (adev->flags.ejectable)
+			return true;
+#endif
+
+	return false;
+}
+
 static int ioat_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
 {
 	void __iomem * const *iomap;
@@ -155,6 +184,11 @@ static int ioat_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
 	struct ioatdma_device *device;
 	int err;
 
+	if (ioat_pci_has_ejectable_acpi_ancestor(pdev)) {
+		dev_dbg(&pdev->dev, "ignore ejectable IOAT device.\n");
+		return -ENODEV;
+	}
+
 	err = pcim_enable_device(pdev);
 	if (err)
 		return err;
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/