linux-kernel - Re: [PATCH] Warnings : Fixed 80 character length warning in rtw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150708010810.GA2563@sreenath-gentoo.lan>
Date:	Tue, 7 Jul 2015 21:08:10 -0400
From:	Sreenath Madasu <sreenath.madasu@...il.com>
To:	Valdis.Kletnieks@...edu
Cc:	jteki@...nedev.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Warnings : Fixed 80 character length warning in rtw_ap.c

The kernelnewbies.org guide said "For your first patch, only pick one
warning". That is the reason why I fixed one warning.

Thanks
Sreenath
On Tue, Jul 07, 2015 at 03:32:50PM -0400, Valdis.Kletnieks@...edu wrote:
> On Mon, 06 Jul 2015 21:53:26 -0400, Sreenath Madasu said:
> > When the checkpatch.pl script was run, it showed lines with length
> > more than 80 characters in rtw_ap.c file. Fixed line number 382 by
> > breaking it up into two lines within 80 characters.
> 
> 
> > -				stainfo_offset = rtw_stainfo_offset(pstapriv, psta);
> > +				stainfo_offset =
> > +					rtw_stainfo_offset(pstapriv, psta);
> >  				if (stainfo_offset_valid(stainfo_offset))
> >  					chk_alive_list[chk_alive_num++] = stainfo_offset;
> 
> Umm... Sreenath?
> 
> There's 97 more occurrences of the same problem in that file.
> 
> All:  Is it time to kill that checkpatch test, or hide it behind a non-default
> flag, to prevent code churn?
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/