linux-kernel - Re: [PATCH 5/5] usb: gadget: atmel_usba

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <559CDD4A.2000609@atmel.com>
Date:	Wed, 8 Jul 2015 10:20:26 +0200
From:	Nicolas Ferre <nicolas.ferre@...el.com>
To:	Robert Baldyga <r.baldyga@...sung.com>,
	<gregkh@...uxfoundation.org>, <balbi@...com>
CC:	<vinc94@...il.com>, <hamohammed.sa@...il.com>,
	<tapaswenipathak@...il.com>, <roberta.dobrescu@...il.com>,
	<hgujulan@...teon.com>, <chris@...vick.com>, <mina86@...a86.com>,
	<andrzej.p@...sung.com>, <devel@...verdev.osuosl.org>,
	<linux-kernel@...r.kernel.org>, <linux-usb@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>, <m.szyprowski@...sung.com>
Subject: Re: [PATCH 5/5] usb: gadget: atmel_usba_udc: add missing ret value
 check

Le 07/07/2015 16:02, Robert Baldyga a écrit :
> Add missing return value check. In case of error print debug message
> and return error code.
> 
> Signed-off-by: Robert Baldyga <r.baldyga@...sung.com>

Yes, it's indeed missing:
Acked-by: Nicolas Ferre <nicolas.ferre@...el.com>

Thanks, bye.

> ---
>  drivers/usb/gadget/udc/atmel_usba_udc.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c
> index 4095cce0..37d414e 100644
> --- a/drivers/usb/gadget/udc/atmel_usba_udc.c
> +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c
> @@ -1989,6 +1989,10 @@ static struct usba_ep * atmel_udc_of_init(struct platform_device *pdev,
>  		ep->can_isoc = of_property_read_bool(pp, "atmel,can-isoc");
>  
>  		ret = of_property_read_string(pp, "name", &name);
> +		if (ret) {
> +			dev_err(&pdev->dev, "of_probe: name error(%d)\n", ret);
> +			goto err;
> +		}
>  		ep->ep.name = name;
>  
>  		ep->ep_regs = udc->regs + USBA_EPT_BASE(i);
> 


-- 
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/