| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <559CE207.5000507@users.sourceforge.net> Date: Wed, 8 Jul 2015 10:40:39 +0200 From: SF Markus Elfring <elfring@...rs.sourceforge.net> To: Greg Kroah-Hartman <gregkh@...uxfoundation.org> Cc: Chris Park <chris.park@...el.com>, Dean Lee <dean.lee@...el.com>, Johnny Kim <johnny.kim@...el.com>, Rachel Kim <rachel.kim@...el.com>, linux-wireless@...r.kernel.org, devel@...verdev.osuosl.org, Julia Lawall <julia.lawall@...6.fr>, kernel-janitors@...r.kernel.org, LKML <linux-kernel@...r.kernel.org> Subject: Re: staging: wilc1000: One function call less in mac_ioctl() after error detection >> The kfree() function was called in two cases by the mac_ioctl() function >> during error handling even if the passed variable did not contain a pointer >> for a valid data item. >> >> * This implementation detail could be improved by the introduction >> of another jump label. >> >> * Drop an unnecessary initialisation for the variable "buff" then. > > That's a different issue, please fix it in a separate patch. I have got an other opinion here. This update suggestion depends on a small source code clean-up from the previous patch, doesn't it? Do you want that I split the second suggestion from this series into more steps? Regards, Markus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists