[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <alpine.DEB.2.11.1507081245120.5134@nanos>
Date: Wed, 8 Jul 2015 12:48:34 +0200 (CEST)
From: Thomas Gleixner <tglx@...utronix.de>
To: Marc Zyngier <marc.zyngier@....com>
cc: Bjorn Helgaas <bhelgaas@...gle.com>,
Jiang Liu <jiang.liu@...ux.intel.com>,
Jason Cooper <jason@...edaemon.net>,
linux-arm-kernel@...ts.infradead.org, linux-pci@...r.kernel.org,
linux-kernel@...r.kernel.org, Yijing Wang <wangyijing@...wei.com>,
Ma Jun <majun258@...wei.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@....com>
Subject: Re: [PATCH v3 09/15] irqchip: gicv3-its: Split PCI/MSI code from
the core ITS driver
On Tue, 7 Jul 2015, Marc Zyngier wrote:
> +static int its_pci_msi_prepare(struct irq_domain *domain, struct device *dev,
> + int nvec, msi_alloc_info_t *info)
> +{
> + struct pci_dev *pdev;
> + struct its_pci_alias dev_alias;
> +
> + if (!dev_is_pci(dev))
> + return -EINVAL;
> +
> + pdev = to_pci_dev(dev);
> + dev_alias.pdev = pdev;
> + dev_alias.count = nvec;
> +
> + pci_for_each_dma_alias(pdev, its_get_pci_alias, &dev_alias);
> +
> + return its_msi_prepare(domain, dev_alias.dev_id, dev_alias.count, info);
I don't think you need its_msi_prepare() exposed to child
drivers. Something like
domain->parent->ops->msi_prepare()
should do the trick.
Thanks,
tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists