linux-kernel - Re: [PATCH 1/2] ASoC: rt5645: Fix missing free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150708111437.GQ11162@sirena.org.uk>
Date:	Wed, 8 Jul 2015 12:14:37 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Koro Chen <koro.chen@...iatek.com>
Cc:	perex@...ex.cz, tiwai@...e.de, lgirdwood@...il.com,
	srv_heupstream@...iatek.com, linux-kernel@...r.kernel.org,
	alsa-devel@...a-project.org, bardliao@...ltek.com,
	oder_chiou@...ltek.com
Subject: Re: [PATCH 1/2] ASoC: rt5645: Fix missing free_irq

On Wed, Jul 08, 2015 at 04:25:50PM +0800, Koro Chen wrote:

> The driver does not free irq if snd_soc_register_codec fails.
> It does not return error when request irq failed, either.
> Fix this by using devm_request_threaded_irq(), and returns when error.

Unfortunately this isn't safe...

> -	if (i2c->irq)
> -		free_irq(i2c->irq, rt5645);
> -
>  	cancel_delayed_work_sync(&rt5645->jack_detect_work);

This work item is queued up by the interrupt handler so we need to
unregister the interrupt before we cancel any pending work otherwise
it's possible that the interrupt may fire after we cancelled the work.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)