linux-kernel - Re: [RFC PATCH v3 1/4] STM trace event: Adding generic buffer interface driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87fv4yn6dd.fsf@ashishki-desk.ger.corp.intel.com>
Date:	Wed, 08 Jul 2015 16:09:18 +0300
From:	Alexander Shishkin <alexander.shishkin@...ux.intel.com>
To:	Peter Zijlstra <peterz@...radead.org>,
	Chunyan Zhang <zhang.chunyan@...aro.org>
Cc:	rostedt@...dmis.org, mingo@...hat.com, mathieu.poirier@...aro.org,
	serge.broslavsky@...aro.org, broonie@...nel.org,
	zhang.lyra@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH v3 1/4] STM trace event: Adding generic buffer interface driver

Peter Zijlstra <peterz@...radead.org> writes:

> On Tue, Jul 07, 2015 at 06:10:40PM +0800, Chunyan Zhang wrote:
>> +config STM_TRACE_EVENT
>> +	tristate "Redirect/copy the output from kernel trace event to STM engine"
>
> How does tristate make sense here? You're using it unconditionally for
> in-kernel tracepoints. This must be bool, which in turn makes the whole
> STM thing bool afaiu.

That would make the whole STM thing a bool. I'd rather we used stm
output *conditionally* by somehow plugging into tracepoint output, say
with a jump label or something. Haven't had time to think about it yet.

Regards,
--
Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/