[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <xa1t7fqadam8.fsf@mina86.com>
Date: Wed, 08 Jul 2015 15:47:43 +0200
From: Michal Nazarewicz <mina86@...a86.com>
To: Robert Baldyga <r.baldyga@...sung.com>, gregkh@...uxfoundation.org,
balbi@...com
Cc: nicolas.ferre@...el.com, dan.carpenter@...cle.com,
sergei.shtylyov@...entembedded.com, andrzej.p@...sung.com,
m.szyprowski@...sung.com, devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
Robert Baldyga <r.baldyga@...sung.com>
Subject: Re: [PATCH v2 5/5] usb: gadget: atmel_usba_udc: add missing ret value check
On Wed, Jul 08 2015, Robert Baldyga wrote:
> Add missing return value check. In case of error print debug message
> and return error code.
>
> Signed-off-by: Robert Baldyga <r.baldyga@...sung.com>
> Acked-by: Nicolas Ferre <nicolas.ferre@...el.com>
Acked-by: Michal Nazarewicz <mina86@...a86.com>
> ---
> drivers/usb/gadget/udc/atmel_usba_udc.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c
> index 4095cce0..37d414e 100644
> --- a/drivers/usb/gadget/udc/atmel_usba_udc.c
> +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c
> @@ -1989,6 +1989,10 @@ static struct usba_ep * atmel_udc_of_init(struct platform_device *pdev,
> ep->can_isoc = of_property_read_bool(pp, "atmel,can-isoc");
>
> ret = of_property_read_string(pp, "name", &name);
> + if (ret) {
> + dev_err(&pdev->dev, "of_probe: name error(%d)\n", ret);
> + goto err;
> + }
> ep->ep.name = name;
>
> ep->ep_regs = udc->regs + USBA_EPT_BASE(i);
> --
> 1.9.1
>
--
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o
..o | Computer Science, Michał “mina86” Nazarewicz (o o)
ooo +--<mpn@...gle.com>--<xmpp:mina86@...ber.org>--ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists