lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 8 Jul 2015 19:01:59 +0300 From: Vladimir Davydov <vdavydov@...allels.com> To: Michal Hocko <mhocko@...nel.org> CC: Johannes Weiner <hannes@...xchg.org>, Andrew Morton <akpm@...ux-foundation.org>, Tejun Heo <tj@...nel.org>, Oleg Nesterov <oleg@...hat.com>, Greg Thelen <gthelen@...gle.com>, KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>, KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>, <linux-mm@...ck.org>, LKML <linux-kernel@...r.kernel.org>, Michal Hocko <mhocko@...e.cz> Subject: Re: [PATCH 4/8] memcg, mm: move mem_cgroup_select_victim_node into vmscan On Wed, Jul 08, 2015 at 02:27:48PM +0200, Michal Hocko wrote: > From: Michal Hocko <mhocko@...e.cz> > > We currently have only one caller of mem_cgroup_select_victim_node which > is sitting in mm/vmscan.c and which is already wrapped by CONFIG_MEMCG > ifdef. Now that we have struct mem_cgroup visible outside of > mm/memcontrol.c we can move the function and its dependencies there. > This even shrinks the code size by few bytes: > > text data bss dec hex filename > 478509 65806 26384 570699 8b54b mm/built-in.o.before > 478445 65806 26384 570635 8b50b mm/built-in.o.after > > Signed-off-by: Michal Hocko <mhocko@...e.cz> I dislike this patch, because I don't see any reason why logic specific to per memcg reclaim should live in the file representing the global reclaim path. With such an approach you may end up with moving mem_cgroup_low, mem_cgroup_soft_limit_reclaim, etc to vmscan.c, because they are used only there. I don't think it's right. Thanks, Vladimir -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists