linux-kernel - Re: [PATCH 28/42] x86, boot: Allow 64bit EFI kernel to be loaded above 4G

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150708180020.GC5598@codeblueprint.co.uk>
Date:	Wed, 8 Jul 2015 19:00:20 +0100
From:	Matt Fleming <matt@...eblueprint.co.uk>
To:	Kees Cook <keescook@...omium.org>
Cc:	Yinghai Lu <yinghai@...nel.org>, "H. Peter Anvin" <hpa@...or.com>,
	Baoquan He <bhe@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 28/42] x86, boot: Allow 64bit EFI kernel to be loaded
 above 4G

On Tue, 07 Jul, at 04:12:26PM, Kees Cook wrote:
> > @@ -301,7 +301,7 @@ _start:
> >         # Part 2 of the header, from the old setup.S
> >
> >                 .ascii  "HdrS"          # header signature
> > -               .word   0x020d          # header version number (>= 0x0105)
> > +               .word   0x020e          # header version number (>= 0x0105)
> >                                         # or else old loadlin-1.5 will fail)
> >                 .globl realmode_swtch
> >  realmode_swtch:        .word   0, 0            # default_switch, SETUPSEG
> > @@ -478,6 +478,7 @@ pref_address:               .quad LOAD_PHYSICAL_ADDR        # preferred load addr
> >  #endif
> >  init_size:             .long INIT_SIZE         # kernel initialization size
> >  handover_offset:       .long 0                 # Filled in by build.c
> > +ext_code32_start:      .long 0                 # werid one!
> 
> Comment is a typo?
 
Yeah, this was one of the things I pointed out the last time this patch
was sent and it's disheartening to see it wasn't fixed (as trivial as it
may be),

  https://lkml.kernel.org/r/20150224215501.GB9758@codeblueprint.co.uk

-- 
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/