linux-kernel - Re: [PATCH] power: bq27x00_battery: Destroy battery

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <mqdwpy9stab.fsf@c203.arch.suse.de>
Date:	Thu, 09 Jul 2015 09:07:40 +0200
From:	Johannes Thumshirn <jthumshirn@...e.de>
To:	Pali Rohár <pali.rohar@...il.com>
Cc:	Sebastian Reichel <sre@...nel.org>,
	"Dmitry Eremin-Solenikov" <dbaryshkov@...il.com>,
	David Woodhouse <dwmw2@...radead.org>,
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
	Johannes Thumshirn <jthumshirn@...e.de>
Subject: Re: [PATCH] power: bq27x00_battery: Destroy battery_id IDR on module exit

Pali Rohár <pali.rohar@...il.com> writes:

> On Wednesday 08 July 2015 17:18:20 Johannes Thumshirn wrote:
>> Destroy battery_id IDR on module exit, reclaiming the allocated
>> memory.
>> 
>> This was detected by the following semantic patch (written by Luis
>> Rodriguez <mcgrof@...e.com>)
>> <SmPL>
>> @ defines_module_init @
>> declarer name module_init, module_exit;
>> declarer name DEFINE_IDR;
>> identifier init;
>> @@
>> 
>> module_init(init);
>> 
>> @ defines_module_exit @
>> identifier exit;
>> @@
>> 
>> module_exit(exit);
>> 
>> @ declares_idr depends on defines_module_init && defines_module_exit
>> @ identifier idr;
>> @@
>> 
>> DEFINE_IDR(idr);
>> 
>> @ on_exit_calls_destroy depends on declares_idr &&
>> defines_module_exit @ identifier declares_idr.idr,
>> defines_module_exit.exit;
>> @@
>> 
>> exit(void)
>> {
>>  ...
>>  idr_destroy(&idr);
>>  ...
>> }
>> 
>> @ missing_module_idr_destroy depends on declares_idr &&
>> defines_module_exit && !on_exit_calls_destroy @ identifier
>> declares_idr.idr, defines_module_exit.exit;
>> @@
>> 
>> exit(void)
>> {
>>  ...
>>  +idr_destroy(&idr);
>> }
>> </SmPL>
>> 
>> Signed-off-by: Johannes Thumshirn <jthumshirn@...e.de>
>> ---
>>  drivers/power/bq27x00_battery.c | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/drivers/power/bq27x00_battery.c
>> b/drivers/power/bq27x00_battery.c index b6b9837..99180d2 100644
>> --- a/drivers/power/bq27x00_battery.c
>> +++ b/drivers/power/bq27x00_battery.c
>> @@ -1106,6 +1106,7 @@ static void __exit bq27x00_battery_exit(void)
>>  {
>>  	bq27x00_battery_platform_exit();
>>  	bq27x00_battery_i2c_exit();
>> +	idr_destroy(&battery_id);
>>  }
>>  module_exit(bq27x00_battery_exit);
>
> Hello, I see that none power supply kernel driver is calling 
> idr_destroy() at module exit time. So if this patch is needed for 
> bq27x00_battery module, then it is needed also for other charger/battery 
> modules...

You're right. I'll post a follow up for this with (this time hopefully)
all battery drivers included.

-- 
Johannes Thumshirn                                       Storage
jthumshirn@...e.de                             +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/