linux-kernel - Re: [PATCH] SCSI-libcxgbi: Deletion of an unnecessary check before the function call "dst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <559E322D.30705@users.sourceforge.net>
Date:	Thu, 9 Jul 2015 10:34:53 +0200
From:	SF Markus Elfring <elfring@...rs.sourceforge.net>
To:	"James E. J. Bottomley" <JBottomley@...allels.com>,
	linux-scsi@...r.kernel.org
Cc:	LKML <linux-kernel@...r.kernel.org>,
	kernel-janitors@...r.kernel.org,
	Julia Lawall <julia.lawall@...6.fr>
Subject: Re: [PATCH] SCSI-libcxgbi: Deletion of an unnecessary check before
 the function call "dst_release"

> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Fri, 21 Nov 2014 09:15:10 +0100
> 
> The dst_release() function tests whether its argument is NULL and then
> returns immediately. Thus the test around the call is not needed.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
>  drivers/scsi/cxgbi/libcxgbi.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/cxgbi/libcxgbi.c b/drivers/scsi/cxgbi/libcxgbi.c
> index addd1dd..95d2654 100644
> --- a/drivers/scsi/cxgbi/libcxgbi.c
> +++ b/drivers/scsi/cxgbi/libcxgbi.c
> @@ -798,8 +798,7 @@ void cxgbi_sock_closed(struct cxgbi_sock *csk)
>  		return;
>  	if (csk->saddr.sin_port)
>  		sock_put_port(csk);
> -	if (csk->dst)
> -		dst_release(csk->dst);
> +	dst_release(csk->dst);
>  	csk->cdev->csk_release_offload_resources(csk);
>  	cxgbi_sock_set_state(csk, CTP_CLOSED);
>  	cxgbi_inform_iscsi_conn_closing(csk);
> 

Would you like to integrate this update suggestion
into another source code repository?

Regards,
Markus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/