linux-kernel - Re: [PATCH v4.0 for testing] nbd: Fix timeout detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150709132120.GJ7573@pengutronix.de>
Date:	Thu, 9 Jul 2015 15:21:20 +0200
From:	Markus Pargmann <mpa@...gutronix.de>
To:	Hermann Lauer <Hermann.Lauer@....uni-heidelberg.de>
Cc:	nbd-general@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
	kernel@...gutronix.de, Michal Belczyk <belczyk@....krakow.pl>
Subject: Re: [PATCH v4.0 for testing] nbd: Fix timeout detection

Hi Hermann,

On Thu, Jul 09, 2015 at 10:06:52AM +0200, Hermann Lauer wrote:
> Hello Markus,
> 
> > On Fri, Apr 24, 2015 at 09:35:33AM +0200, Markus Pargmann wrote:
> > > At the moment the nbd timeout just detects hanging tcp operations. This
> > > is not enough to detect a hanging or bad connection as expected of a
> > > timeout.
> > ...
> > > Cc: Michal Belczyk <belczyk@....krakow.pl>
> > > Cc: Hermann Lauer <Hermann.Lauer@....uni-heidelberg.de>
> > > Signed-off-by: Markus Pargmann <mpa@...gutronix.de>
> > > [mpa: Backported to 4.0]
> > > 
> > > Signed-off-by: Markus Pargmann <mpa@...gutronix.de>
> > > ---
> > > 
> > > This patch is only for testing at the moment. I will backport the final patch
> > > for the stable tree at the end.
> > 
> > tested with 4.0 - timeout works as expected after
> > disconnecting the ethernet.
> > No hang or unexpected kernel message.
> 
> still no problems so far - may I ask if the patch made his way upstream ?
> If you already submitted it, knowing the commit would be nice to tell
> it to the Debian maintainers.

Thanks for reporting. Sorry for the delay, but I queued the patch for
4.3 yesterday.

The patch will not go into the stable kernel trees. This is somehow more
of a feature than a bug. The timeout works as it was designed. This
patch just makes the timeout handling more intuitive for the user.

I hope this is fine for you.

Best regards,

Markus

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)