linux-kernel - Re: [PATCH v4 6/7] imx27: dt: add support of internal rtc

Open Source and information security mailing list archives

Message-ID: <20150709143257.GJ23464@tiger>
Date:	Thu, 9 Jul 2015 22:32:57 +0800
From:	Shawn Guo <shawnguo@...nel.org>
To:	Philippe Reynes <tremyfr@...il.com>
Cc:	a.zummo@...ertech.it, alexandre.belloni@...e-electrons.com,
	shawn.guo@...aro.org, kernel@...gutronix.de,
	linux@....linux.org.uk, rtc-linux@...glegroups.com,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v4 6/7] imx27: dt: add support of internal rtc

On Sat, Jul 04, 2015 at 01:15:19AM +0200, Philippe Reynes wrote:
> Add support of internal rtc on imx27.
> 
> Signed-off-by: Philippe Reynes <tremyfr@...il.com>
> ---
>  arch/arm/boot/dts/imx27.dtsi |   10 ++++++++++
>  1 files changed, 10 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi
> index b69be5c..38e6e84 100644
> --- a/arch/arm/boot/dts/imx27.dtsi
> +++ b/arch/arm/boot/dts/imx27.dtsi
> @@ -144,6 +144,16 @@
>  				clock-names = "ipg", "per";
>  			};
>  
> +			rtc: rtc@...07000 {
> +				compatible = "fsl,imx21-rtc";
> +				reg = <0x10007000 0x1000>;
> +				interrupts = <22>;
> +				clocks = <&clks IMX27_CLK_CKIL>,
> +					 <&clks IMX27_CLK_RTC_IPG_GATE>;
> +				clock-names = "rtc", "ipg";
> +				status = "disabled";

It has neither pin-out nor board level configuration.  For such device,
it makes more sense to drop status = "disabled" and enable the device by
default.  The bonus point would be that patch #7 in the series can be
saved.

Shawn

> +			};
> +
>  			kpp: kpp@...08000 {
>  				compatible = "fsl,imx27-kpp", "fsl,imx21-kpp";
>  				reg = <0x10008000 0x1000>;
> -- 
> 1.7.4.4
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives