linux-kernel - Re: Linux 4.2-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150709144540.GA27723@kroah.com>
Date:	Thu, 9 Jul 2015 07:45:40 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Shuah Khan <shuahkh@....samsung.com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Ming Lei <ming.lei@...onical.com>,
	Shuah Khan <shuahkhan@...il.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: Linux 4.2-rc1

On Thu, Jul 09, 2015 at 07:44:04AM -0600, Shuah Khan wrote:
> On 07/09/2015 07:10 AM, Shuah Khan wrote:
> > On 07/08/2015 09:17 PM, Linus Torvalds wrote:
> >> On Wed, Jul 8, 2015 at 5:58 PM, Ming Lei <ming.lei@...onical.com> wrote:
> >>> On Thu, Jul 9, 2015 at 1:29 AM, Linus Torvalds
> >>> <torvalds@...ux-foundation.org> wrote:
> >>>> Also, it looks like you need to hold the "fw_lock" to even look at
> >>>> that pointer, since the buffer can get reallocated etc.
> >>>
> >>> Yes, the above code with holding 'fw_lock' is right fix for the issue since
> >>> sysfs read can happen anytime, and there is one race between firmware
> >>> request abort and reading uevent of sysfs.
> >>
> >> So if fw_priv->buf is NULL, what should we do?
> >>
> >> Should we skip the TIMEOUT= and ASYNC= fields too?
> >>
> >> Something like the attached, perhaps?
> >>
> >> Shuah, how reproducible is this? Does this (completely untested) patch
> >> make any difference?
> >>
> > 
> > Happened both times I booted 4.2-rc1 up, so I would say 100% so far.
> > I will test with your patch and report results.
> > 
> 
> Yes. This patch fixed the problem.

That's great, but what changed recently to cause this problem to happen?
Any chance you can bisect to the problem commit?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/