linux-kernel - Re: [PATCH v4 0/3] net: dsa: mv88e6xxx: add support for VLAN Table Unit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150709.110135.225522890258902682.davem@davemloft.net>
Date:	Thu, 09 Jul 2015 11:01:35 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	vivien.didelot@...oirfairelinux.com
Cc:	andrew@...n.ch, netdev@...r.kernel.org, sfeldma@...il.com,
	jiri@...nulli.us, f.fainelli@...il.com, linux@...ck-us.net,
	linux-kernel@...r.kernel.org, kernel@...oirfairelinux.com
Subject: Re: [PATCH v4 0/3] net: dsa: mv88e6xxx: add support for VLAN Table
 Unit

From: Vivien Didelot <vivien.didelot@...oirfairelinux.com>
Date: Wed, 8 Jul 2015 13:13:16 -0400 (EDT)

> You're right. There's a single operation to clear the STU and VTU. I
> will send a follow-up patch to send this command during the switch
> setup.

Fix known bugs in the patch series, within the patch series, since it
hasn't been merged yet.

Don't say "I'll fix this bug later", because we can fix it now.

Also as others have noted, this patch set creates an intermediate
state where functionality is effectively broken.  So it is illogical
to knowingly merge this patch series as-is.  You'll have to piece
together all of the changes necessary such that the series is fully
bisectable, which means at every patch along the way things function
properly and do not break.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/