linux-kernel - [PATCH 4/5] kmod: Remove unecessary explicit wide CPU affinity setting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1436465237-22031-5-git-send-email-fweisbec@gmail.com>
Date:	Thu,  9 Jul 2015 20:07:16 +0200
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	LKML <linux-kernel@...r.kernel.org>
Cc:	Frederic Weisbecker <fweisbec@...il.com>,
	Oleg Nesterov <oleg@...hat.com>,
	Christoph Lameter <cl@...ux.com>,
	Rik van Riel <riel@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: [PATCH 4/5] kmod: Remove unecessary explicit wide CPU affinity setting

The call_usermodehelper_exec_[a]sync() kernel threads are created by
unbound workqueues precisely because we want them to be affine to all
CPUs, irrespective of any call_usermodehelper() caller with possibly
reduced CPU affinity. So this explicit all-CPUs wide affinity forcing is
useless.

Not only useless it even adds disturbance on isolated CPUs in nohz full
configurations where users set the unbound workqueues low level cpumask
to a reduced set in order to execute non-user-critical work on
housekeeping dedicated CPUs. This reduced affinity is naturally
inherited to usermodehelper kernel threads but the explicit call to
set_cpus_allowed_ptr() breaks that.

So just remove it.

Cc: Rik van Riel <riel@...hat.com>
Cc: Oleg Nesterov <oleg@...hat.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>
Cc: Christoph Lameter <cl@...ux.com>
Signed-off-by: Frederic Weisbecker <fweisbec@...il.com>
---
 kernel/kmod.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/kernel/kmod.c b/kernel/kmod.c
index 9ffb24c..d190178 100644
--- a/kernel/kmod.c
+++ b/kernel/kmod.c
@@ -221,9 +221,6 @@ static int call_usermodehelper_exec_async(void *data)
 	flush_signal_handlers(current, 1);
 	spin_unlock_irq(&current->sighand->siglock);

-	/* We can run anywhere, unlike our parent (unbound workqueue). */
-	set_cpus_allowed_ptr(current, cpu_all_mask);
-
 	/*
 	 * Our parent is the unbound workqueue, which runs with elevated
 	 * scheduling priority. Avoid propagating that into the userspace child.
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/