linux-kernel - Re: [PATCH] ext4 crypto: remove unneeded assignation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 9 Jul 2015 21:04:55 +0200
From:	Laurent Navet <laurent.navet@...il.com>
To:	"Darrick J. Wong" <darrick.wong@...cle.com>
Cc:	tytso@....edu, adilger.kernel@...ger.ca,
	linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ext4 crypto: remove unneeded assignation

Make sense,
I send a v2, thank's

2015-07-08 22:01 UTC+02:00, Darrick J. Wong <darrick.wong@...cle.com>:
> On Wed, Jul 08, 2015 at 09:51:15PM +0200, Laurent Navet wrote:
>> Return value of ext4_derive_key_aes() is stored but never used before
>> being overwritten.
>> Also fix coverity CID 1309760.
>>
>> Signed-off-by: Laurent Navet <laurent.navet@...il.com>
>> ---
>>  fs/ext4/crypto_key.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/ext4/crypto_key.c b/fs/ext4/crypto_key.c
>> index 442d24e..92f9172 100644
>> --- a/fs/ext4/crypto_key.c
>> +++ b/fs/ext4/crypto_key.c
>> @@ -218,7 +218,7 @@ retry:
>>  	BUILD_BUG_ON(EXT4_AES_128_ECB_KEY_SIZE !=
>>  		     EXT4_KEY_DERIVATION_NONCE_SIZE);
>>  	BUG_ON(master_key->size != EXT4_AES_256_XTS_KEY_SIZE);
>> -	res = ext4_derive_key_aes(ctx.nonce, master_key->raw,
>> +	ext4_derive_key_aes(ctx.nonce, master_key->raw,
>>  				  raw_key);
>
> I don't think it's a good idea to drop the error code on the floor and keep
> going as if nothing bad had happened.
>
> --D
>
>>  got_key:
>>  	ctfm = crypto_alloc_ablkcipher(cipher_str, 0, 0);
>> --
>> 2.1.4
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
>> the body of a message to majordomo@...r.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>


-- 
« On ne résout pas un problème avec les modes de pensée qui l’ont engendré. »
« You cannot solve current problems with current thinking. Current
problems are the result of current thinking »
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/