linux-kernel - Re: [RESEND 2][PATCH v4] hexdump: fix for non-aligned buffers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <02992F9C-657D-4ED9-B47E-379C477A44DA@gmail.com>
Date:	Thu, 9 Jul 2015 21:08:04 +0200
From:	"H. Mijail" <hmijail@...il.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	David Howells <dhowells@...hat.com>,
	Vivek Goyal <vgoyal@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Jiri Kosina <trivial@...nel.org>, Joe Perches <joe@...ches.com>
Subject: Re: [RESEND 2][PATCH v4] hexdump: fix for non-aligned buffers


> On 09 Jul 2015, at 09:16, Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
> 
> On Thu, Jul 9, 2015 at 4:07 AM, Andrew Morton <akpm@...ux-foundation.org> wrote:
>>> The other alternative in Documentation/unaligned-memory-access.txt is the
>>> macro get_unaligned() from asm/unaligned.h. However, using get_unaligned()
>>> would mean a much more intrusive patch, since each case of the groupsize
>>> would be changed, and anyway we would still need to check
>>> CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS to avoid penalising everyone.
>> 
>> Actually, I think using get_unaligned() would be a better solution.
>> For architectures which have CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS=y,
>> get_unaligned() should be fast - just one instruction.

D’oh! You’re right, of course.

>> 
>> This way we avoid having different-appearing output on different
>> architectures.
> 
> Definitely.
> 
> A less optimal get_unaligned() will just be noise in the snprintf() processing
> time.
> 

OK, so thanks Andrew and Geert for your comments. I’ll reimplement using get_unaligned.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/