[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150709204956.GF2859@worktop.programming.kicks-ass.net>
Date: Thu, 9 Jul 2015 22:49:56 +0200
From: Peter Zijlstra <peterz@...radead.org>
To: Chris Metcalf <cmetcalf@...hip.com>
Cc: linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
rth@...ddle.net, vgupta@...opsys.com, linux@....linux.org.uk,
will.deacon@....com, hskinnemoen@...il.com, realmz6@...il.com,
dhowells@...hat.com, rkuo@...eaurora.org, tony.luck@...el.com,
geert@...ux-m68k.org, james.hogan@...tec.com, ralf@...ux-mips.org,
jejb@...isc-linux.org, benh@...nel.crashing.org,
heiko.carstens@...ibm.com, davem@...emloft.net, mingo@...nel.org
Subject: Re: [PATCH] tile: Provide atomic_{or,xor,and}
On Thu, Jul 09, 2015 at 04:38:17PM -0400, Chris Metcalf wrote:
> Implement atomic logic ops -- atomic_{or,xor,and}.
>
> For tilegx, these are relatively straightforward; the architecture
> provides atomic "or" and "and", both 32-bit and 64-bit. To support
> xor we provide a loop using "cmpexch".
>
> For the older 32-bit tilepro architecture, we have to extend
> the set of low-level assembly routines to include 32-bit "and",
> as well as all three 64-bit routines. Somewhat confusingly,
> some 32-bit versions are already used by the bitops inlines, with
> parameter types appropriate for bitops, so we have to do a bit of
> casting to match "int" to "unsigned long".
>
> Signed-off-by: Chris Metcalf <cmetcalf@...hip.com>
> ---
> Peter, I'm guessing you should just take this into your series,
> rather than my pushing it through the tile tree.
Awesome, thanks! Yeah, I'll collect the lot.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists