linux-kernel - Re: [PATCH 3/4] mm, oom: organize oom context into struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1507091407530.17177@chino.kir.corp.google.com>
Date:	Thu, 9 Jul 2015 14:09:13 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	Michal Hocko <mhocko@...nel.org>
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Jakob Unterwurzacher <jakobunt@...il.com>, linux-mm@...ck.org,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/4] mm, oom: organize oom context into struct

On Thu, 9 Jul 2015, Michal Hocko wrote:

> > > From: David Rientjes <rientjes@...gle.com>
> > > 
> > > There are essential elements to an oom context that are passed around to
> > > multiple functions.
> > > 
> > > Organize these elements into a new struct, struct oom_context, that
> > > specifies the context for an oom condition.
> > > 
> > > This patch introduces no functional change.
> > > 
> > > [mhocko@...e.cz: s@..._control@..._context@]
> > > [mhocko@...e.cz: do not initialize on stack oom_context with NULL or 0]
> > > Signed-off-by: David Rientjes <rientjes@...gle.com>
> > > Signed-off-by: Michal Hocko <mhocko@...e.cz>
> > 
> > I hate to appear to be nacking my own patch, but it was correct when 
> > included in my series
> 
> What is incorrect in this patch?

Nothing, the statement is quite clear that it is also correct in my series 
which is much cleaner, reduces stack usage, removes more lines of code 
than yours, and organizes the oom killer code to avoid passing so many 
formals which should have been done long ago.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/