lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 10 Jul 2015 08:40:08 +0200 From: Hannes Reinecke <hare@...e.de> To: Johannes Thumshirn <jthumshirn@...e.de>, Kai Mäkisara <Kai.Makisara@...umbus.fi>, "James E.J. Bottomley" <JBottomley@...n.com> CC: linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] st: Destroy st_index_idr on module exit On 07/08/2015 05:24 PM, Johannes Thumshirn wrote: > Destroy st_index_idr on module exit, reclaiming the allocated memory. > > This was detected by the following semantic patch (written by Luis Rodriguez > <mcgrof@...e.com>) > <SmPL> > @ defines_module_init @ > declarer name module_init, module_exit; > declarer name DEFINE_IDR; > identifier init; > @@ > > module_init(init); > > @ defines_module_exit @ > identifier exit; > @@ > > module_exit(exit); > > @ declares_idr depends on defines_module_init && defines_module_exit @ > identifier idr; > @@ > > DEFINE_IDR(idr); > > @ on_exit_calls_destroy depends on declares_idr && defines_module_exit @ > identifier declares_idr.idr, defines_module_exit.exit; > @@ > > exit(void) > { > ... > idr_destroy(&idr); > ... > } > > @ missing_module_idr_destroy depends on declares_idr && defines_module_exit && !on_exit_calls_destroy @ > identifier declares_idr.idr, defines_module_exit.exit; > @@ > > exit(void) > { > ... > +idr_destroy(&idr); > } > </SmPL> > > Signed-off-by: Johannes Thumshirn <jthumshirn@...e.de> > --- > drivers/scsi/st.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c > index 3f25b8f..79ac024 100644 > --- a/drivers/scsi/st.c > +++ b/drivers/scsi/st.c > @@ -4427,6 +4427,7 @@ static void __exit exit_st(void) > unregister_chrdev_region(MKDEV(SCSI_TAPE_MAJOR, 0), > ST_MAX_TAPE_ENTRIES); > class_unregister(&st_sysfs_class); > + idr_destroy(&st_index_idr); > printk(KERN_INFO "st: Unloaded.\n"); > } > > Reviewed-by: Hannes Reinecke <hare@...e.de> Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@...e.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists