linux-kernel - Re: [PATCH] ALSA: aoa: Drop owner assignment from i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 10 Jul 2015 09:54:58 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
Cc:	Johannes Berg <johannes@...solutions.net>,
	Jaroslav Kysela <perex@...ex.cz>,
	linuxppc-dev@...ts.ozlabs.org (open list:AOA (Apple Onboard Audio) ALSA
	DRIVER),
	alsa-devel@...a-project.org (moderated list:AOA (Apple Onboard Audio)
	ALSA DRIVER), linux-kernel@...r.kernel.org (open list)
Subject: Re: [PATCH] ALSA: aoa: Drop owner assignment from i2c_driver

On Fri, 10 Jul 2015 08:39:02 +0200,
Krzysztof Kozlowski wrote:
> 
> i2c_driver does not need to set an owner because i2c_register_driver()
> will set it.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>

Applied, thanks.


Takashi

> 
> ---
> 
> The coccinelle script which generated the patch was sent here:
> http://www.spinics.net/lists/kernel/msg2029903.html
> ---
>  sound/aoa/codecs/onyx.c | 1 -
>  sound/aoa/codecs/tas.c  | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/sound/aoa/codecs/onyx.c b/sound/aoa/codecs/onyx.c
> index 23c371ecfb6b..a04edff8b729 100644
> --- a/sound/aoa/codecs/onyx.c
> +++ b/sound/aoa/codecs/onyx.c
> @@ -1050,7 +1050,6 @@ MODULE_DEVICE_TABLE(i2c,onyx_i2c_id);
>  static struct i2c_driver onyx_driver = {
>  	.driver = {
>  		.name = "aoa_codec_onyx",
> -		.owner = THIS_MODULE,
>  	},
>  	.probe = onyx_i2c_probe,
>  	.remove = onyx_i2c_remove,
> diff --git a/sound/aoa/codecs/tas.c b/sound/aoa/codecs/tas.c
> index 364c7c4416e8..78ed1ffbf786 100644
> --- a/sound/aoa/codecs/tas.c
> +++ b/sound/aoa/codecs/tas.c
> @@ -939,7 +939,6 @@ MODULE_DEVICE_TABLE(i2c,tas_i2c_id);
>  static struct i2c_driver tas_driver = {
>  	.driver = {
>  		.name = "aoa_codec_tas",
> -		.owner = THIS_MODULE,
>  	},
>  	.probe = tas_i2c_probe,
>  	.remove = tas_i2c_remove,
> -- 
> 1.9.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/