linux-kernel - Re: [RFC][PATCH 03/24] arm: Provide atomic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150710102436.GQ7557@n2100.arm.linux.org.uk>
Date:	Fri, 10 Jul 2015 11:24:36 +0100
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
	rth@...ddle.net, vgupta@...opsys.com, will.deacon@....com,
	hskinnemoen@...il.com, realmz6@...il.com, dhowells@...hat.com,
	rkuo@...eaurora.org, tony.luck@...el.com, geert@...ux-m68k.org,
	james.hogan@...tec.com, ralf@...ux-mips.org, jejb@...isc-linux.org,
	benh@...nel.crashing.org, heiko.carstens@...ibm.com,
	davem@...emloft.net, cmetcalf@...hip.com, mingo@...nel.org
Subject: Re: [RFC][PATCH 03/24] arm: Provide atomic_{or,xor,and}

On Thu, Jul 09, 2015 at 08:02:23PM +0200, Peter Zijlstra wrote:
> On Thu, Jul 09, 2015 at 07:28:58PM +0200, Peter Zijlstra wrote:
> > @@ -320,6 +323,9 @@ static inline long long atomic64_##op##_
> >  
> >  ATOMIC64_OPS(add, adds, adc)
> >  ATOMIC64_OPS(sub, subs, sbc)
> > +ATOMIC64_OP(and, and, and)
> > +ATOMIC64_OP(or, or, or)
> 
> Hmm, reading through them, this should be:
> 
> ATOMIC64_OP(or, orr, orr)
> 
> I suppose, not sure why the compiler didn't complain, maybe because
> there aren't any users..

Yep, as it creates a static inline function, the code will only get
produced if something uses it, and which point the assembler would have
picked up on the error.

In any case, with that modification, the patch then _looks_ correct to
me for both atomic and atomic64 additions.  Not tested myself.

I guess as you're only looking for comments at the moment, there's
little point in acking it just yet.

-- 
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/