linux-kernel - Re: [PATCH v2] coresight: replicator: Use module_platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK-LDb+Yg+wQJ_bM3Usc=hoK-jDOxHy5AsUOAbmg+-dVnOM4KA@mail.gmail.com>
Date:	Fri, 10 Jul 2015 17:17:20 +0530
From:	Vaishali Thakkar <vthakkar1994@...il.com>
To:	Paul Bolle <pebolle@...cali.nl>
Cc:	Mathieu Poirier <mathieu.poirier@...aro.org>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] coresight: replicator: Use module_platform_driver

On Fri, Jul 10, 2015 at 2:30 PM, Paul Bolle <pebolle@...cali.nl> wrote:
> On vr, 2015-07-10 at 08:53 +0530, Vaishali Thakkar wrote:
>> I thought about this solution before sending this patch. But I was not
>> sure about it. Thanks for the explanation. I will send v3 with this
>> change.
>>
>> Can I add Suggested By: Paul Bolle <pebolle@...cali.nl>
>
> That should be "Suggested-by:". The net effect would be that, if my
> suggestion turns out to be unwise, fan mail will also hit my INBOX,
> right? Anyhow, fine with me.

Ok. Thanks.

> By the way, there's more module specific stuff in
> drivers/hwtracing/coresight/. And there's no tristate symbol to be found
> in its Kconfig file. So I'd guess there are a few other cleanups
> possible too, if someone cared enough to have a closer look at that.
>

Yes. It seems that introducing something like builtin_amba_driver()
can be useful for files which are using module_amba_driver now . But I'm
not sure if Mathieu is ok with it or not? If it seems useful to him, then I
can go for it.

>
> Paul Bolle



-- 
Vaishali
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/