linux-kernel - Re: [PATCH] Lindent: Handle missing indent gracefully

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1436529101.24866.39.camel@perches.com>
Date:	Fri, 10 Jul 2015 04:51:41 -0700
From:	Joe Perches <joe@...ches.com>
To:	Jean Delvare <jdelvare@...e.de>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] Lindent: Handle missing indent gracefully

On Fri, 2015-07-10 at 13:47 +0200, Jean Delvare wrote:
> If indent is not found, bail out immediately instead of spitting
> random shell script error messages.

OK, but can't we just delete Lindent instead?

> --- linux-4.2-rc0.orig/scripts/Lindent	2015-06-22 07:05:43.000000000 +0200
> +++ linux-4.2-rc0/scripts/Lindent	2015-07-10 13:45:56.864031472 +0200
> @@ -1,6 +1,9 @@
>  #!/bin/sh
>  PARAM="-npro -kr -i8 -ts8 -sob -l80 -ss -ncs -cp1"
>  RES=`indent --version`
> +if [ "$RES" = "" ]; then
> +	exit 1
> +fi
>  V1=`echo $RES | cut -d' ' -f3 | cut -d'.' -f1`
>  V2=`echo $RES | cut -d' ' -f3 | cut -d'.' -f2`
>  V3=`echo $RES | cut -d' ' -f3 | cut -d'.' -f3`
> 



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/