| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 10 Jul 2015 09:01:40 -0400 (EDT)
From: Julia Lawall <julia.lawall@...6.fr>
To: Krzysztof Kozlowski <k.kozlowski@...sung.com>
cc: Julia Lawall <Julia.Lawall@...6.fr>,
Gilles Muller <Gilles.Muller@...6.fr>,
Nicolas Palix <nicolas.palix@...g.fr>,
Michal Marek <mmarek@...e.cz>,
Wolfram Sang <wsa@...-dreams.de>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
cocci@...teme.lip6.fr, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] coccinelle: api: extend spatch for dropping unnecessary
owner
Acked-by: Julia Lawall <Julia.Lawall@...6.fr>
As a semantic patch, it looks fine. Have you sent any patches based on
it? I find hundreds of occurrences.
julia
On Fri, 10 Jul 2015, Krzysztof Kozlowski wrote:
> i2c_add_driver (through i2c_register_driver) sets the owner field so we
> can drop it also from i2c drivers, just like from platform drivers.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
> ---
> scripts/coccinelle/api/platform_no_drv_owner.cocci | 73 ++++++++++++++++++++++
> 1 file changed, 73 insertions(+)
>
> diff --git a/scripts/coccinelle/api/platform_no_drv_owner.cocci b/scripts/coccinelle/api/platform_no_drv_owner.cocci
> index e065b9e714fc..c5e3f73f2054 100644
> --- a/scripts/coccinelle/api/platform_no_drv_owner.cocci
> +++ b/scripts/coccinelle/api/platform_no_drv_owner.cocci
> @@ -9,11 +9,14 @@ virtual org
> virtual report
>
> @match1@
> +declarer name module_i2c_driver;
> declarer name module_platform_driver;
> declarer name module_platform_driver_probe;
> identifier __driver;
> @@
> (
> + module_i2c_driver(__driver);
> +|
> module_platform_driver(__driver);
> |
> module_platform_driver_probe(__driver, ...);
> @@ -28,6 +31,15 @@ identifier match1.__driver;
> }
> };
>
> +@...1_i2c depends on match1 && patch && !context && !org && !report@
> +identifier match1.__driver;
> +@@
> + static struct i2c_driver __driver = {
> + .driver = {
> +- .owner = THIS_MODULE,
> + }
> + };
> +
> @match2@
> identifier __driver;
> @@
> @@ -37,6 +49,8 @@ identifier __driver;
> platform_driver_probe(&__driver, ...)
> |
> platform_create_bundle(&__driver, ...)
> +|
> + i2c_add_driver(&__driver)
> )
>
> @fix2 depends on match2 && patch && !context && !org && !report@
> @@ -48,6 +62,15 @@ identifier match2.__driver;
> }
> };
>
> +@...2_i2c depends on match2 && patch && !context && !org && !report@
> +identifier match2.__driver;
> +@@
> + static struct i2c_driver __driver = {
> + .driver = {
> +- .owner = THIS_MODULE,
> + }
> + };
> +
> // ----------------------------------------------------------------------------
>
> @fix1_context depends on match1 && !patch && (context || org || report)@
> @@ -61,6 +84,17 @@ position j0;
> }
> };
>
> +@...1_i2c_context depends on match1 && !patch && (context || org || report)@
> +identifier match1.__driver;
> +position j0;
> +@@
> +
> + static struct i2c_driver __driver = {
> + .driver = {
> +* .owner@j0 = THIS_MODULE,
> + }
> + };
> +
> @fix2_context depends on match2 && !patch && (context || org || report)@
> identifier match2.__driver;
> position j0;
> @@ -72,6 +106,17 @@ position j0;
> }
> };
>
> +@...2_i2c_context depends on match2 && !patch && (context || org || report)@
> +identifier match2.__driver;
> +position j0;
> +@@
> +
> + static struct i2c_driver __driver = {
> + .driver = {
> +* .owner@j0 = THIS_MODULE,
> + }
> + };
> +
> // ----------------------------------------------------------------------------
>
> @script:python fix1_org depends on org@
> @@ -81,6 +126,13 @@ j0 << fix1_context.j0;
> msg = "No need to set .owner here. The core will do it."
> coccilib.org.print_todo(j0[0], msg)
>
> +@...ipt:python fix1_i2c_org depends on org@
> +j0 << fix1_i2c_context.j0;
> +@@
> +
> +msg = "No need to set .owner here. The core will do it."
> +coccilib.org.print_todo(j0[0], msg)
> +
> @script:python fix2_org depends on org@
> j0 << fix2_context.j0;
> @@
> @@ -88,6 +140,13 @@ j0 << fix2_context.j0;
> msg = "No need to set .owner here. The core will do it."
> coccilib.org.print_todo(j0[0], msg)
>
> +@...ipt:python fix2_i2c_org depends on org@
> +j0 << fix2_i2c_context.j0;
> +@@
> +
> +msg = "No need to set .owner here. The core will do it."
> +coccilib.org.print_todo(j0[0], msg)
> +
> // ----------------------------------------------------------------------------
>
> @script:python fix1_report depends on report@
> @@ -97,6 +156,13 @@ j0 << fix1_context.j0;
> msg = "No need to set .owner here. The core will do it."
> coccilib.report.print_report(j0[0], msg)
>
> +@...ipt:python fix1_i2c_report depends on report@
> +j0 << fix1_i2c_context.j0;
> +@@
> +
> +msg = "No need to set .owner here. The core will do it."
> +coccilib.report.print_report(j0[0], msg)
> +
> @script:python fix2_report depends on report@
> j0 << fix2_context.j0;
> @@
> @@ -104,3 +170,10 @@ j0 << fix2_context.j0;
> msg = "No need to set .owner here. The core will do it."
> coccilib.report.print_report(j0[0], msg)
>
> +@...ipt:python fix2_i2c_report depends on report@
> +j0 << fix2_i2c_context.j0;
> +@@
> +
> +msg = "No need to set .owner here. The core will do it."
> +coccilib.report.print_report(j0[0], msg)
> +
> --
> 1.9.1
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists