linux-kernel - Re: [PATCH] udf: Don't corrupt unalloc spacetable when writing it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150710140155.GA29102@quack.suse.cz>
Date:	Fri, 10 Jul 2015 16:01:55 +0200
From:	Jan Kara <jack@...e.cz>
To:	Steve Magnani <steve.magnani@...idescorp.com>
Cc:	Jan Kara <jack@...e.cz>, linux-kernel@...r.kernel.org,
	"Steven J. Magnani" <steve@...idescorp.com>
Subject: Re: [PATCH] udf: Don't corrupt unalloc spacetable when writing it

On Thu 09-07-15 13:20:27, Steve Magnani wrote:
> 
> 
> On 07/09/2015 10:16 AM, Jan Kara wrote:
> >On Tue 07-07-15 13:06:05, Steven J. Magnani wrote:
> >>For a UDF filesystem configured with an Unallocated Space Table,
> >>a filesystem operation that triggers an update to the table results
> >>in on-disk corruption that prevents remounting:
> >>
> >>   udf_read_tagged: tag version 0x0000 != 0x0002 || 0x0003, block 274
> >>
> >>For example:
> >>   1. Create a filesystem
> >>       $ mkudffs --media-type=hd --blocksize=512 --lvid=BUGTEST \
> >>               --vid=BUGTEST --fsid=BUGTEST --space=unalloctable \
> >>               /dev/mmcblk0
> >>
> >>   2. Mount it
> >>       # mount /dev/mmcblk0 /mnt
> >>
> >>...
> >So the patch looks good to me. But what kind of mkudffs are you using?
> >Because when I use the command you wrote into the changelog, I cannot mount
> >the filesystem. The kernel complains about:
> >
> >UDF-fs: error (device ubdb): udf_read_inode: (ino 274) failed ident=256
> >mount: /dev/ubdb: can't read superblock
> >
> >Now ident 256 is TAG_IDENT_FSD (file set descriptor). So apparently my
> >mkudffs doesn't create proper partition table with your parameters...
> >
> >
> It identifies itself as:
>     mkudffs 1.0.0b2 for UDF FS 1.0.0-cvs, 2002/02/09
> 
> ...from Ubuntu udftools 1.0.0b3-14.2.

OK, I've fixed my mkudffs and verified that your patch indeed fixes the
problem. Thanks. I have merged the patch to my tree and will push it to
Linus.

								Honza
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/