linux-kernel - Re: [PATCH v3] phy: rcar-gen2 usb: Add Host/Function switching for USB0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 10 Jul 2015 19:36:10 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Phil Edworthy <phil.edworthy@...esas.com>,
	Kishon Vijay Abraham I <kishon@...com>
CC:	Rob Herring <robh+dt@...nel.org>, Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-usb@...r.kernel.org, linux-sh@...r.kernel.org
Subject: Re: [PATCH v3] phy: rcar-gen2 usb: Add Host/Function switching for
 USB0

Hello.

On 07/07/2015 02:55 PM, Phil Edworthy wrote:

> Instead of statically selecting the PHY connection to either the
> USBHS (Function) or PCI0 (Host) IP blocks, this change allows the
> dts to specifiy gpio pins for the vbus and id signals. Additional

    These GPIOs don't have anything to do with the PHY, they're interfacing 
Maxim MAX3355 OTG chip for which I have submitted the extcon driver.

> gpio pins are used to control power to an external OTG device and
> an override to turn vbus on/off.

> Note: the R-Car USB PHY only allows this Host/Function switching
> on channel 0.

> This has been tested on a r8a7791 based Koelsch board, which uses
> a MAX3355 device to supply vbus power when needed.

> Signed-off-by: Phil Edworthy <phil.edworthy@...esas.com>

    I'm inclined to NAK this. You're modifying the wrong driver, I think.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/