linux-kernel - Re: [PATCH] Lindent: Handle missing indent gracefully

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1436547847.24866.50.camel@perches.com>
Date:	Fri, 10 Jul 2015 10:04:07 -0700
From:	Joe Perches <joe@...ches.com>
To:	Jean Delvare <jdelvare@...e.de>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] Lindent: Handle missing indent gracefully

On Fri, 2015-07-10 at 15:36 +0200, Jean Delvare wrote:
> Hi Joe,

howdy Jean.

> Le Friday 10 July 2015 à 04:51 -0700, Joe Perches a écrit :
> > On Fri, 2015-07-10 at 13:47 +0200, Jean Delvare wrote:
> > > If indent is not found, bail out immediately instead of spitting
> > > random shell script error messages.
> > 
> > OK, but can't we just delete Lindent instead?
> 
> Because...?

It's just not very useful in today's development space.

indent is quite bad at handling long lines.

It wraps code at arbitrary points to fit a column boundary
rather than for readability or sensibility.

Code that may have deep indentation using a few spaces
per block level can look horrible post Lindent.

For instance, reiserfs commit bd4c625c061c
("reiserfs: run scripts/Lindent on reiserfs code")

There are other tools that reflow whitespace styles.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/