linux-kernel - RE: [PATCH] acpi/apei: free lists of resources in einj and erst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3908561D78D1C84285E8C5FCA982C28F32AA5A72@ORSMSX114.amr.corp.intel.com>
Date:	Fri, 10 Jul 2015 18:14:09 +0000
From:	"Luck, Tony" <tony.luck@...el.com>
To:	Konstantin Khlebnikov <khlebnikov@...dex-team.ru>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	"Chen, Gong" <gong.chen@...ux.intel.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Tomasz Nowicki" <tomasz.nowicki@...aro.org>
Subject: RE: [PATCH] acpi/apei: free lists of resources in einj and erst

--- a/drivers/acpi/apei/einj.c
+++ b/drivers/acpi/apei/einj.c
@@ -379,10 +379,9 @@ static int __einj_error_trigger(u64 trigger_paddr, u32 type,
 			rc = apei_resources_add(&addr_resources,
 				trigger_param_region->address,
 				trigger_param_region->bit_width/8, true);
-			if (rc)
-				goto out_fini;
-			rc = apei_resources_sub(&trigger_resources,
-					&addr_resources);
+			if (!rc)
+				rc = apei_resources_sub(&trigger_resources,
+							&addr_resources);
 		}
 		apei_resources_fini(&addr_resources);
 		if (rc)

This bit looks wrong ... the line right after the this diff ends is
			goto out_fini;

so we'll call apei_resources_fini() twice in the rc!=0 case.

-Tony