lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 10 Jul 2015 15:21:20 -0500 From: Rob Herring <robherring2@...il.com> To: Yinghai Lu <yinghai@...nel.org> Cc: Bjorn Helgaas <bhelgaas@...gle.com>, David Miller <davem@...emloft.net>, David Ahern <david.ahern@...cle.com>, Benjamin Herrenschmidt <benh@...nel.crashing.org>, Wei Yang <weiyang@...ux.vnet.ibm.com>, TJ <linux@....tj>, Yijing Wang <wangyijing@...wei.com>, Andrew Morton <akpm@...ux-foundation.org>, "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Grant Likely <grant.likely@...aro.org>, Rob Herring <robh+dt@...nel.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org> Subject: Re: [PATCH 29/36] of/PCI: Add IORESOURCE_MEM_64 for 64-bit resource On Mon, Jul 6, 2015 at 6:39 PM, Yinghai Lu <yinghai@...nel.org> wrote: > For device resource PREF bit setting under bridge 64-bit pref resource, > we need to make sure only set PREF for 64bit resource, so set > IORESOUCE_MEM_64 for 64bit resource during of device resource flags > parsing. > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=96261 > Link: https://bugzilla.kernel.org/show_bug.cgi?id=96241 As the BZ says, we have several identical functions. Can we fix the drivers/of/address.c version and remove the Sparc versions. The only diff is the generic version converts from be32. I think that should be a nop for Sparc. Rob > Signed-off-by: Yinghai Lu <yinghai@...nel.org> > Cc: Grant Likely <grant.likely@...aro.org> > Cc: Rob Herring <robh+dt@...nel.org> > Cc: devicetree@...r.kernel.org > --- > drivers/of/address.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/of/address.c b/drivers/of/address.c > index 8bfda6a..073125f 100644 > --- a/drivers/of/address.c > +++ b/drivers/of/address.c > @@ -128,9 +128,11 @@ static unsigned int of_bus_pci_get_flags(const __be32 *addr) > flags |= IORESOURCE_IO; > break; > case 0x02: /* 32 bits */ > - case 0x03: /* 64 bits */ > flags |= IORESOURCE_MEM; > break; > + case 0x03: /* 64 bits */ > + flags |= IORESOURCE_MEM | IORESOURCE_MEM_64; > + break; > } > if (w & 0x40000000) > flags |= IORESOURCE_PREFETCH; > -- > 1.8.4.5 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists