linux-kernel - Re: [PATCH v2 3/3] usb: dwc3: gadget: return error if command sent to DEPCMD register fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150711192914.GA24195@saruman.tx.rr.com>
Date:	Sat, 11 Jul 2015 14:29:14 -0500
From:	Felipe Balbi <balbi@...com>
To:	Subbaraya Sundeep Bhatta <subbaraya.sundeep.bhatta@...inx.com>
CC:	"balbi@...com" <balbi@...com>, John Youn <John.Youn@...opsys.com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: Re: [PATCH v2 3/3] usb: dwc3: gadget: return error if command sent
 to DEPCMD register fails

Hi,

On Sat, Jul 11, 2015 at 05:17:32PM +0000, Subbaraya Sundeep Bhatta wrote:
> > > >> Hi Felipe,
> > > >>
> > > >> Just an update on this.
> > > >>
> > > >> I'm trying to get this working with our latest IP with dwc3 from
> > > >> your testing/next branch. It fails the usbtest with a problem
> > > >> unrelated to this patch.
> > > >>.
> > > >> It passes on 4.1.1.
> > > >>
> > > >> I'll have to look into the failure but I won't get to it until next
> > > >> week as I'm off the rest of this week.
> > > >
> > > > interesting... If you could post failure signature, I can help
> > > > looking at it, but I guess it's too late to ask :-)
> > > >
> > > > thanks for helping though
> > > >
> > >
> > >
> > > Hi Felipe,
> > >
> > > Nevermind about my issue, it ended up being a setup-related problem.
> > >
> > > I actually do see the same error as you due to this series of patches.
> > > Except I see it happening before even the first iteration. I get a
> > > completion status of 1 for the Set Endpoint Transfer Resources
> > > command. I'm not sure why this is.
> > >
> > > I don't see any conflict with any previous Transfer Complete.
> 
> Same behavior at my end too. Fails before first iteration and I get
> completion status of 1 for Set Endpoint Resource command. Attached the
> logs of testing done with this patch and without this patch.
> Without this patch I often see completion status of 1 for Set Endpoint
> Transfer Resources command for Bulk and Isoc endpoints but test
> proceeds because driver just logs command completion status and moves
> on. We can revert this patch for time being. IP version is 2.90a.

yeah, that's what I mean, it really seems like it's the IP misbehaving.

John, let's try to figure out what's the root cause of this, we really
want to use command completion status at some point, but for now we need
to revert the patch :-(

Let me know if you want me to log STARS ticket on your solvnet system.

cheers

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)