linux-kernel - Re: [PATCH] MIPS: ath79: irq: Remove the include of drivers/irqchip/irqchip.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.11.1507112233280.20072@nanos>
Date:	Sat, 11 Jul 2015 22:36:26 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Alban Bedel <albeu@...e.fr>
cc:	linux-mips@...ux-mips.org, Ralf Baechle <ralf@...ux-mips.org>,
	Andrew Bresticker <abrestic@...omium.org>,
	Qais Yousef <qais.yousef@...tec.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MIPS: ath79: irq: Remove the include of
 drivers/irqchip/irqchip.h

On Wed, 8 Jul 2015, Alban Bedel wrote:
> We shouldn't include irqchip.h from outside of the drivers/irqchip
> directory. The irq driver should idealy be there, however this not
> trivial at the moment. We still need to support platforms without DT
> support and the interface to the DDR controller still use a custom
> arch specific API.
> 
> For now just redefine the IRQCHIP_DECLARE macro to avoid the cross
> tree include.

The macro has been moved to linux/irqchip.h.

But even if it would still be in drivers/irqchip such a redefine is
even worse than the ../../... include. And the proper solution from
the very beginning would have been to move the macro to the global
header instead of this horrible include.

Sigh,

	tglx

 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/