linux-kernel - Re: V4.1-RC build error after commit 77a3c6f

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 11 Jul 2015 16:30:25 -0500
From:	Larry Finger <Larry.Finger@...inger.net>
To:	LKML <linux-kernel@...r.kernel.org>,
	Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>,
	Mauro Carvalho Chehab <mchehab@....samsung.com>
Subject: Re: V4.1-RC build error after commit 77a3c6f

The subject should say V4.2-RC. Sorry.

Larry

On 07/11/2015 04:27 PM, Larry Finger wrote:
> Beginning with the commit in the subject, I get the following build error:
>
>    CC [M]  drivers/media/v4l2-core/videobuf2-core.o
> drivers/media/v4l2-core/videobuf2-core.c: In function ‘vb2_warn_zero_bytesused’:
> drivers/media/v4l2-core/videobuf2-core.c:1253:2: error: implicit declaration of
> function ‘__WARN’ [-Werror=implicit-function-declaration]
>    __WARN();
>    ^
> cc1: some warnings being treated as errors
>
> My .config is attached.
>
> This problem has been bisected to the following commit:
>
> commit 77a3c6fd90c94f635edb00d4a65f485687538791
> Author: Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>
> Date:   Fri Jun 19 08:50:07 2015 -0300
>
>      [media] vb2: Don't WARN when v4l2_buffer.bytesused is 0 for multiplanar
> buffers
>
>      Commit f61bf13b6a07 ("[media] vb2: add allow_zero_bytesused flag to the
>      vb2_queue struct") added a WARN_ONCE to catch usage of a deprecated API
>      using a zero value for v4l2_buffer.bytesused.
>
>      However, the condition is checked incorrectly, as the v4L2_buffer
>      bytesused field is supposed to be ignored for multiplanar buffers. This
>      results in spurious warnings when using the multiplanar API.
>
>      Fix it by checking v4l2_buffer.bytesused for uniplanar buffers and
>      v4l2_plane.bytesused for multiplanar buffers.
>
>      Fixes: f61bf13b6a07 ("[media] vb2: add allow_zero_bytesused flag to the
> vb2_queue struct")
>
>      Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>
>      Cc: stable@...r.kernel.org # for v4.0
>      Signed-off-by: Mauro Carvalho Chehab <mchehab@....samsung.com>
>
> Thanks,
>
> Larry

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/