lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sat, 11 Jul 2015 16:47:17 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	Paul McKenney <paulmck@...ux.vnet.ibm.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Daniel Wagner <daniel.wagner@...-carit.de>,
	Davidlohr Bueso <dave@...olabs.net>,
	Ingo Molnar <mingo@...hat.com>, Tejun Heo <tj@...nel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/7] Add rcu_sync infrastructure to avoid _expedited() in percpu-rwsem

On Sat, Jul 11, 2015 at 4:35 PM, Oleg Nesterov <oleg@...hat.com> wrote:
>
> Linus, I am mostly trying to convince you. Nobody else objected so far.
> Could you please comment?

I don't mind this part of the series.

It's the whole "do we really want to put the effort into percpu-rwsem
I worry about, as there just aren't that many users.

The conversions made that "too damn special" thing go away, but the
conversions (particularly the big _real_ user, namely fs/locks.c) seem
to have serious performance problems that are quite possibly not
fixable.

So my objection isn't to your change, my objection is to the whole
"right now there are two users, and they both use a global lock, so
*of course* they scale like shit, and this is all just papering over
that much more fundamental problem".

I hate one-off locking. One-off locking with one global lock? Yeah,
that just smells.

                  Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists