linux-kernel - Re: [PATCH v2 10/13] pinctrl: kill off set_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 13 Jul 2015 00:45:58 +0900
From:	Tomasz Figa <tomasz.figa@...il.com>
To:	Rob Herring <robh@...nel.org>
Cc:	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
	Russell King <linux@....linux.org.uk>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	"arm@...nel.org" <arm@...nel.org>,
	Stephen Warren <swarren@...dotorg.org>,
	Lee Jones <lee@...nel.org>,
	Matthias Brugger <matthias.bgg@...il.com>,
	Thomas Abraham <thomas.abraham@...aro.org>,
	Kukjin Kim <kgene@...nel.org>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	linux-rpi-kernel <linux-rpi-kernel@...ts.infradead.org>,
	linux-mediatek@...ts.infradead.org,
	"linux-samsung-soc@...r.kernel.org" 
	<linux-samsung-soc@...r.kernel.org>
Subject: Re: [PATCH v2 10/13] pinctrl: kill off set_irq_flags usage

Hi,

2015-07-12 23:26 GMT+09:00 Rob Herring <robh@...nel.org>:
> set_irq_flags is ARM specific with custom flags which have genirq
> equivalents. Convert drivers to use the genirq interfaces directly, so we
> can kill off set_irq_flags. The translation of flags is as follows:
>
> IRQF_VALID -> !IRQ_NOREQUEST
> IRQF_PROBE -> !IRQ_NOPROBE
> IRQF_NOAUTOEN -> IRQ_NOAUTOEN
>
> For IRQs managed by an irqdomain, the irqdomain core code handles clearing
> and setting IRQ_NOREQUEST already, so there is no need to do this in
> .map() functions and we can simply remove the set_irq_flags calls. Some
> users also set IRQ_NOPROBE and this has been maintained although it is not
> clear that is really needed. There appears to be a great deal of blind
> copy and paste of this code.
>
> Signed-off-by: Rob Herring <robh@...nel.org>
> Acked-by: Linus Walleij <linus.walleij@...aro.org>
> Cc: Stephen Warren <swarren@...dotorg.org>
> Cc: Lee Jones <lee@...nel.org>
> Cc: Matthias Brugger <matthias.bgg@...il.com>
> Cc: Tomasz Figa <tomasz.figa@...il.com>
> Cc: Thomas Abraham <thomas.abraham@...aro.org>
> Cc: Kukjin Kim <kgene@...nel.org>
> Cc: Krzysztof Kozlowski <k.kozlowski@...sung.com>
> Cc: linux-gpio@...r.kernel.org
> Cc: linux-rpi-kernel@...ts.infradead.org
> Cc: linux-arm-kernel@...ts.infradead.org
> Cc: linux-mediatek@...ts.infradead.org
> Cc: linux-samsung-soc@...r.kernel.org
> ---
>  drivers/pinctrl/bcm/pinctrl-bcm2835.c         | 1 -
>  drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 2 --
>  drivers/pinctrl/pinctrl-single.c              | 5 -----
>  drivers/pinctrl/samsung/pinctrl-exynos.c      | 1 -
>  drivers/pinctrl/samsung/pinctrl-exynos5440.c  | 1 -
>  drivers/pinctrl/samsung/pinctrl-s3c24xx.c     | 2 --
>  drivers/pinctrl/samsung/pinctrl-s3c64xx.c     | 2 --

For drivers/pinctrl/samsung:

Acked-by: Tomasz Figa <tomasz.figa@...il.com>

Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/